[stable33] fix: Return type error after #60844#61199
Closed
artonge wants to merge 1 commit into
Closed
Conversation
artonge
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
Collaborator
Author
|
/backport! to stable32 |
3 tasks
Signed-off-by: Louis Chmn <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/return_type_after_60844
branch
from
be6e4ff to
1a10fae
Compare
CarlSchwan
reviewed
Jun 11, 2026
| * The fields to include in the search results | ||
| * | ||
| * @return list<string> | ||
| * @return array |
Member
There was a problem hiding this comment.
that sounds wrong. the new type is less strict
Collaborator
Author
There was a problem hiding this comment.
The error is:
Error: lib/private/Files/Search/SearchQuery.php:98:37: MoreSpecificReturnType: The declared return type 'list<string>' for OC\Files\Search\SearchQuery::getSelectFields is more specific than the inferred return type 'array<array-key, mixed>' (see https://psalm.dev/070)
Not sure what would be the best solution for that, it is not an issue in more recent versions as the return property is typed slightly differently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.